Remove patch for Reicast compilation issue (fixed upstream in https://github.com/reicast/reicast-emulator/pull/914)

lutris / buildbot

41 stars 27 forks source link

Remove patch for Reicast compilation issue (fixed upstream in https://github.com/reicast/reicast-emulator/pull/914) #99

Closed dinoboy197 closed 4 years ago

dinoboy197 commented 4 years ago

This patch is no longer necessary since Reicast fixed this issue upstream and new builds do not have this issue.

Question: how do we get a new build of the latest stable release of Reicast updated as a runner? The latest Reicast update was a few years back. I'm happy to help out here if that takes work off anyone's plate.

RobLoach commented 4 years ago

cd runners/reicast
./build.sh

If you build and verify it's good to go, I could upload the new version for you.

dinoboy197 commented 4 years ago

Good call. Turns out I needed to adjust the build script a bit to:

pull in the latest release tag, not just a random commit from master
add extra libraries added for building
update the directory with linux source

I've verified that the build works on a clean ubuntu bionic container with nothing but the dependencies from the readme at the root of this repo pre-installed.

I've tested this new binary against Dreamcast gdis that would not run in the previous version; they work correctly and completely now. I think we're good with this new version. If any problems turn up, let me know!

RobLoach commented 4 years ago

Thanks so much! Trying the build now.

Built, but I'm not sure it updated correctly. Mind checking? https://lutris.net/files/runners/?sdaffads

dinoboy197 commented 4 years ago

@RobLoach I see the 64-bit build but not a 32-bit version.

Do we need to update anything else in Lutris so that when downloading the Reicast runner, it downloads the new version?