luuksommers / SevenZipSharp.Interop

Other
36 stars 10 forks source link

SevenZipSharp.Interop.NoReferences: fix naming of targets file for importing to work #19

Closed RoadTrain closed 11 months ago

RoadTrain commented 1 year ago

By convention NuGet will only import .targets file from a package if its name matches the package id.

Previously, for package SevenZipSharp.Interop.NoReferences the .targets file name was SevenZipSharp.Interop.targets, which resulted in NuGet not importing it, and as a result 7z.dll weren't copied to the output folder.

This fixes it by copying the .targets file with a correct name. Unfortunately I had to explicitly list all copied files in the .nuspec but I think it's acceptable.

I verified this fix locally, now the binaries get copied to the output folder.

luuksommers commented 11 months ago

Thanks for your PR, I'll publish a new version

luuksommers commented 11 months ago

I've just published the new version to nuget