coderschool review

[vanhensy]

Hi @luuphu25, thanks for your submission. You've done a good job so far in a short time. But unfortunately, some of required features haven't done yet.

You should continue to finish and improve your pre-work then re-submit to us. To be clear, this is missing required feature:

• User can submit a search term to find all posts by titles containing the search term. you can simply do that with single line of to to query with ActiveRecord like this:

  where("title like ?", params[:search])

• User can delete their post. This is common mistake, this feature not work due to missing tether library. Add it in your application.js.erb:

  //= require tether

Try to finish it and add more optional/additional feature will help your submission stand out from others. You can join to discuss more about it with us and other applicants via gitter chat

We're looking forward to see your improvement.

[coderschoolreview]

Hi @luuphu25, Thanks for your hard work. You've done good job so far. This is some feedback from us:

Great things:

• You've done all required features
• All optional features has been implemented
• Nice grid layout
• You used gem friendly-id to make url more friendly and also have a method to change the slug whenever title updated

Suggestions:

• It's great to follow a good Ruby code style. We recommend this: Ruby Style Guide
• You should use apply bootstrap form-group class for your editing form too
• Style flash alerts in bootstrap style. Instead of <p id="notice">Article was successfully destroyed.</p>, consider rendering it as <div class="alert alert-success">Article was successfully destroyed.</div>. Here's an example of how to do it.
• You shouldn't display slug in article details
• Last but not least, you should have validation in your model to prevent user input wrong/empty record. This is sample:

# article.rb
validates :title, :body, presence: true
# comment.rb
validates :message, presence: true

[luuphu25]

thank you. i'll update as soon as