luvit / luv

Bare libuv bindings for lua
Apache License 2.0
831 stars 187 forks source link

`cpu_info` binding might not handle `model` correctly #648

Closed squeek502 closed 1 year ago

squeek502 commented 1 year ago

When running the tests, I noticed that the uv.cpu_info binding was reporting the model for all of my cores as:

model = "AMD Ryzen 5 3600 6-Core Processor              "

The extra space at the end of the string looks fishy, but I haven't looked into it yet to know where the potential bug is at.

squeek502 commented 1 year ago

Doesn't have the extra space at the end for me on Linux:

model = "AMD Ryzen 5 3600 6-Core Processor"

so this might be Windows-only Libuv bug.

squeek502 commented 1 year ago

Turns out this isn't a bug in libuv either, the actual registry value it's getting this info from on my Windows installation actually has these spaces at the end.