search

luvit / luv

Bare libuv bindings for lua
Apache License 2.0
831 stars 187 forks source link

Use a special metatable for thread userdata arguments #728

Closed javalikescript closed 2 weeks ago

javalikescript commented 2 weeks ago

This is a proposal for handling thread and async userdata arguments.

The current implementation copies the userdata block of raw memory, sets the same metatable then removes it after the callback. This implementation requires the userdata usage to be thread-safe and not used after the callback.

As far as I see the main use case for passing userdata consists in passing async to the thread callback. It is not possible to check if a userdata is thread-safe. The userdata cannot be used after the callback which is fine for thread but not for async.

This change consists in letting the caller opt-in to pass the metatable by providing a dedicated metatable suffixed _ref. Such metatable is provided for uv_async with no close nor gc. There is still a major issue as the async could be garbage collected on the main side.

Another option would be to forbid all userdata arguments except async or not setting the metatable at all.

javalikescript commented 2 weeks ago

Closed in favor of #729