search

lv2 / lilv

LV2 host library
ISC License
37 stars 20 forks source link

Avoid memory leak when dynmanifest returns no plugin subjects #25

Closed mfisher31 closed 4 years ago

mfisher31 commented 5 years ago

This adds an internal function to free LilvDynManifest in a consistent way. world.c was just calling free(...) on it after loading the library & getting no plugins from the lv2_dyn_manifest_get_subjects handler.

mfisher31 commented 5 years ago

Ping! @drobilla

drobilla commented 5 years ago

Noted, but I'm curious how this came about. I was under the impression that I could probably just remove this whole thing and nobody would notice.

mfisher31 commented 5 years ago

I was experimenting with making a "generic" UI which could be loaded for any plugin. The use case would be a new LV2 host that wants to show plugin UIs immediately without fleshing out the host-side implementation right away. (By implementation, I mean having smart GUI logic that builds out the UI interface according the metadata in the turtle)

Anyhow, I was messing with dynmanifest to generate turtle entries so the generic UI can be related to all installed plugins. Long story short, my dynmanifest doesn't create new plugins. Instead it adds relational data like...

<http://example.com/plugin> ui:ui <http://example.com/generic/ui> .

... so the host could load this UI for any installed plugin. Came up with this for a way destroy it so ref count stays consistent.

drobilla commented 4 years ago

I see. Weird :)

I took a superficially slightly different approach because I didn't want to add files or build system boilerplate for a mostly-dead feature, but merged a more or less equivalent fix as 5ae973b. Thanks.