lwang-astro
commented
3 years ago What is the purpose of your download script? Do you want to download MOBSE instead of using the version on PeTar GitHub for users, or use this routine for development only by yourself?
I don't recommend the former one because it breaks the principle of Git. Everytime when user use this routine, the MOBSE directory will change. The users will have a risk that cannot pull update anymore because of file changes (merge request instead). This will bring chaos and confusion of version control. If you want users to always use your MOBSE Git version. I would recommend to do similar to what I did for the Galpy package interface. The Galpy source code is not in PeTar. Users always need to install Galpy separately, like SDAR and FDPS. Users need to update Galpy themselves when any update is available. In this case, it is necessary to delete all MOBSE Fortran source codes in PeTar (mobse directory in bse-interface) and only provide configure option to check the source path of MOBSE. However, there are some routines that were not in original BSE and MOBSE. I will not be possible to maintain those routines in MOBSE in the future. One possibility to solve this issue is to move those routines out of bse and mobse directory and put in a common place that all BSE based codes share the routines. Even so, I think your MOBSE version is still not the same as the standalone version because the argument of e.g. evolv2 has changed to match the interface of PeTar.
If your purpose is only for development yourself, i.e., everytime when you use the download script, you will pull all changes of MOBSE in PeTar to the original repo, there is no need to add this download script to the original repo, unless you would like me to use it to update MOBSE in the future.
GiacobboNicola
I added the possibility to download MOBSE from its own repo. This will help me to maintain the MOBSE in PeTar. I checked my fork and it seems to work properly.