search

lwang-astro / PeTar

PeTar is a high-performance N-body code for modelling the evolution of star clusters and tidal streams, including the effect of galactic potential, dynamics of binary and hierarchical system, single and binary stellar evolution.
MIT License
71 stars 19 forks source link

Misleading citation #26

Closed pavlikva closed 2 years ago

pavlikva commented 2 years ago

In the definition of the core radius:

def calcCoreRadius(self, particle): """ Calculate core radius, using Casertano & Hut (1985) method:

The method with squares, that is used to calculate the core radius, actually does not come from Casertano & Hut but from NBODY5. Check Sverre's book Eq.(15.4). Thanks!

lwang-astro commented 2 years ago

From Portegies Zwart et al. 2010 ARAA, "[The square is used rather than the first power, as originally suggested by Casertano & Hut (1985), to stabilize the algorithm and make it less sensitive to outliers.]". I think the citation to Casertano & Hut (1985) is not wrong, but I can add both references.

pavlikva commented 2 years ago

Thanks. I would include all three then: Cassertano & Hut, Sverre's book and Simon's paper.