lwhay / asterixdb

Automatically exported from code.google.com/p/asterixdb
0 stars 0 forks source link

Passing a wrong dataflow helper factory to secondary index drop operator #772

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
I just spotted this while working on adding support for lsm component filters:

If you look in the class IndexOperations, you will see that we always pass the 
LSMBTreeDataflowHelperFactory to the drop operator--no matter what's the index 
type. I guess this bug didn't surface because in most cases the index to be 
dropped is already registered with the dataset cycle life manager. But I guess 
the issue will appear if the index is being dropped after restarting the 
asterix instance.

Assigning it to Zack (since he thankfully agreed to look at this) for further 
investigation.

Original issue reported on code.google.com by salsuba...@gmail.com on 15 May 2014 at 2:38

GoogleCodeExporter commented 9 years ago
This code will work for the current LSM BTree, LSM RTree and LSM Inverted index 
even when using the LSMBTreeDataflowHelperFactory. The dataflow helper created 
will simply activate the indexes as LSM BTree using the btree and bloomfilter 
file and will ignore the rtree and inverted index components. Since this is a 
drop, it is fine as the whole index directory is deleted during the operation. 
I imagine it will not work for any index that doesn't have a btree and a 
bloomfilter components. i.e (LSM RTree with anti-matter tuples) as activating 
the index will throw an exception.

Original comment by bamou...@gmail.com on 15 May 2014 at 4:19