search

lwille / node-gphoto2

A Node.js wrapper for libgphoto2
MIT License
298 stars 91 forks source link

How to keep images on camera? #98

Closed philipptrenz closed 6 years ago

philipptrenz commented 6 years ago

Hi @lwille, thanks so much for your work! 👍

I'm currently migrating my photo booth software from executing the CLI interface to your library. Triggering the CLI and writing the images to the file system was the best way for me to go in 2016 😅 The only thing I couldn't find was a way to keep the images on the camera. I selected the capturetarget properly, but they won't stay on the sd card like they do with gphoto2 --capture-image-and-download --keep.

Did I miss anything?

philipptrenz commented 6 years ago

Ah, found it in camera_helpers.cc, line 380. So it's a feature request. I think the best way to go is to add bool keep to take_picture_request and check before deleting. Maybe you want to take a look? Otherwise I'll try, but I'm quite inexperienced with bindings to JavaScript.

lwille commented 6 years ago

Just give it a shot, I don’t have a camera to test. If you create a PR I’d happily review your code