search

lwojcik / eleventy-template-bliss

Single-column blog template for Eleventy focused on simplicity without sacrificing functionality
https://eleventy-bliss.lkmt.us/
MIT License
84 stars 19 forks source link

Remove third-party dependencies from GitHub Actions workflow #115

Closed lucascantor closed 5 months ago

lucascantor commented 5 months ago

Use modern GitHub Actions deployment method for GitHub Pages

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
eleventy-bliss ✅ Ready (Inspect) Visit Preview Apr 8, 2024 7:10pm
lwojcik commented 5 months ago

Hi @lucascantor, this looks like a great PR. Thanks a lot!

I'll give it some testing around the weekend and merge it soon.

lucascantor commented 5 months ago

Honestly I'm not super confident I have the expertise to say this is better, but in my humble opinion, eliminating unofficial / third-party GitHub Actions is ideal where possible.

I also think this means you can remove the build-gh-pages script in package.json entirely...?

lwojcik commented 5 months ago

Honestly I'm not super confident I have the expertise to say this is better, but in my humble opinion, eliminating unofficial / third-party GitHub Actions is ideal where possible.

I agree. What you provided is way better and cleaner.

I also think this means you can remove the build-gh-pages script in package.json entirely...?

I'm not sure. The point of npm run build-gh-pages is to provide a working example of a GitHub Pages deployment (e.g. inside a custom subdirectory provided by pathPrefix property) alongside the same setup intended for domain root. Even after the changes provided by you, the Action still uses npm run build-gh-pages to build the site.

lwojcik commented 5 months ago

@lucascantor awesome job, thank you very much!

Merging it now, will also update my blog post and credit you.