search

lwojcik / eleventy-template-bliss

Single-column blog template for Eleventy focused on simplicity without sacrificing functionality
https://eleventy-bliss.lkmt.us/
MIT License
84 stars 19 forks source link

Fix pagination bug #116

Closed lucascantor closed 5 months ago

lucascantor commented 5 months ago

add trailing slash to newLocation

allows setting window.location.href value behind CDNs such as AWS CloudFront

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
eleventy-bliss ✅ Ready (Inspect) Visit Preview Apr 7, 2024 4:23pm
lucascantor commented 5 months ago

@lwojcik this eliminates unexpected jumpButton behavior I was seeing in my GitHub pages deployment behind AWS CloudFront.

For example, before this change, trying to jump to page 2 would navigate to https://username.github.io/reponame/blogdomain.com/2 instead of the expected https://blogdomain.com/2

lwojcik commented 5 months ago

LGTM. Thank you!