search

lynks-- / lifebar

Transparent workspace bar for i3 window manager.
GNU General Public License v2.0
36 stars 6 forks source link

Can't change workspaces with mouse wheel #3

Closed ViktorNova closed 10 years ago

ViktorNova commented 10 years ago

My #1 missed feature from i3bar!

lynks-- commented 10 years ago

I have added this today, but left it in the progressive branch for now as I am not 100% convinced it is bug-free. Let me know if you have any trouble using it. I will leave this issue open :)

ViktorNova commented 10 years ago

Sweet, that was quick! =D Works good-on dual monitors too! I only noticed 2 things that feel weird coming from i3bar:

1: Workspaces wrap around instead of stopping on the first/last workspaces for that screen 2: Only works when the cursor is positioned over the workspace area, instead of the whole bar (or empty parts of the bar)

lynks-- commented 10 years ago

I'll make the wrap-around configurable. I agree; I prefer it if it stops.

I could make workspace switching across the empty area of the bar. Right now I am planning to have the different modules be interactive in different ways - like mousing over the time works now to set an alarm. Say mouse wheeling over the volume module (TODO) would change volume, over thermal could control fan speed, etc.

For that reason there was a min and max x coord that the workspaces will respond to, and it made sense to set that to the workspace buttons for now.

Anyway, I agree that the workspace switching is something you are likely to do most often, so will make the 'blank' area where there are no modules also switch workspaces.

ViktorNova commented 10 years ago

Sounds awesome! I do like how you're making lifebar more fancy and having other uses for the mouse wheel, that's going to be really cool. Having the blank area control workspace switching sounds perfect! =D

lynks-- commented 10 years ago

OK, all of that has been added now. The blank area responds to the scroll wheel for workspace switching, and wrapping is configurable, but defaults to off. I have also merged to master because it seems to work ok.

ViktorNova commented 10 years ago

This is awesome! A little lag when switching, but works great! You rock

lynks-- commented 10 years ago

Yeah I have noticed that the workspaces indicators lag when using the mouse to switch workspaces (either by clicking or with the wheel) This does not occur when switching directly from i3 using keybinds or i3-msg, which indicates that the lag is in lifebar sending the command to i3. I am looking into this issue currently.

ViktorNova commented 10 years ago

cool!