search

lyzhng / tabble

Table of Contents Tab
1 stars 0 forks source link

Refactor to TypeScript #11

Closed lyzhng closed 4 years ago

lyzhng commented 4 years ago

🟡 As of 6a09953f142e51af34eaf7a96edbc5e47aa985ae., some errors may persist due to browser not being declared. I plan on fixing that soon but that involves some modularization. There is another one that's like this in background.ts for handleMessage(...). For some reason, it should return Promise<IRequest>, but it continues to error out and say IRequest.data does not match. I will look into that.

lyzhng commented 4 years ago

Fixed in #20. webextension-polyfill-ts helped with the typing. Also having a tsconfig.json does too.