lzim / teampsd

Team PSD is using GitHub, R and RMarkdown as part of our free and open science workflow.
GNU General Public License v3.0
9 stars 23 forks source link

wk2 sept_epic Bug: SIM_UI not reading Data_UI team data file correctly #2734

Closed emilymetcalf114 closed 2 years ago

emilymetcalf114 commented 2 years ago

During facilitate_Workflow on 9/6, @MattMoore2 mentioned how the data that the team has been looking at in the Data_UI and the data file uploaded into the Sim_UI look different.

He pulled the data that @lzim helped out with the week before, and the data looks very different than what was seen in the psychotherapy model. Exceedingly high weird numbers that don't make any sense:

image

He mentioned that they were able to go back to an older data file (from July 26) that was accurate enough for them to proceed, which looked like this: image

@dlkibbe mentioned that she has seen this happen to her too in the past, and she thought that last time the issue was the Sim_UI not reading the data correctly, and going back to the old data set should be fine.

  1. Discussed at facilitate_workflow on 9/6, not sure when @MattMoore2 discovered it initially.
  2. Shared world
jamesmrollins commented 2 years ago

@emilymetcalf114 This may actually be a data ui problem. To evaluate, we need to look at both files side-by-side. I will check it out and advise you.

jamesmrollins commented 2 years ago

@emilymetcalf114 I did a deep dive this morning and found a few things that may illuminate this problem.

  1. I believe the target team data file is empty. This would cause the model to not operate correctly.
  2. What is an anomaly, however, is the model is returning values of any kind. If the model is run in the client, it simply says "Need a value" for the "GetDirectConstants" function, In the sim, it should return a zero.
  3. The sim appears to be loading a correct team data file just fine.
  4. So what doesn't make sense, logically, is that the sim loads one parameters file correctly, but not the other.

No Team Data in clinic_selections File

image

Model Not Showing Zeros in the Data Variables

image

Sim Appears to Load Correct Team Data File Correctly

image

image

lzim commented 2 years ago

Thanks so much @jamesmrollins for your hard work on this! I don't know the history for why Ok City tried to pull the version 2 file.

And, both faciltiators are out next week with @dlounsbu & @lzim covering next week. We used the file that is working properly. So, I think we can close this bug, unless the team requires us to open again next week when we meet with them.