lzim / teampsd

Team PSD is using GitHub, R and RMarkdown as part of our free and open science workflow.
GNU General Public License v3.0
9 stars 23 forks source link

2023_wk2_jun_#story_b: As a facility self-registering user, I need to login to Sim UI #2964

Closed jamesmrollins closed 7 months ago

jamesmrollins commented 1 year ago

Definition of Done

lijenn commented 1 year ago

Functional Requirements discussed 2023_05_31

Dependency: User Roles


Goal: Everyone can self-register at mtl.how/sim


DECISION: Retain _Ind, _Shared, and _Team worlds (no need to change to facility or sta3n world.

Facilitator

Lead

Member

All Roles

Next Steps: Look into why we implemented "Research Arm".

jamesmrollins commented 1 year ago

Cross Reference: #2960

jamesmrollins commented 1 year ago

@lzim and @lijenn - I found the #2702 Facilitator Registration Process card and could not find any rationale as to why we included study information on the registration popup.

lijenn commented 1 year ago

@jamesmrollins @lzim I wonder if it's because we tried to have redundancy from Dynamics? That's the only other place that I think of where we have to manually input the research arm.

I also don't recall this field having any impacts on generating TT reports for blue or red teams? Might need to double check on this.

jamesmrollins commented 1 year ago

2978 contains the wireframe for the above. Updated dependency to indicated "blocked" by QA DEV.

jamesmrollins commented 1 year ago

Updated Wireframe based on feedback from QA DEV:

Sim UI Release 3.7 - Self Registration and Fac Dash Update.pdf

jamesmrollins commented 1 year ago

@hirenp-esquare - this is released for Development.

Updated Wireframe based on feedback from PI review:

Sim UI Release 3.7 - Self Registration and Fac Dash Update.pdf

jamesmrollins commented 1 year ago

@hirenp-esquare - this wireframe updated with the items we discussed regarding team naming convention.

Sim UI Release 3.7 - Self Registration and Fac Dash Update.pdf

sta6a.xlsx

jamesmrollins commented 1 year ago

Hi @hirenp-esquare see below for edits to self registration

Change link name on login

image

lijenn commented 1 year ago

Hi @jamesmrollins @hirenp-esquare ! Please review the feedback below from my user test session w/ @ljmoody:

lijenn commented 1 year ago

Adding some additional feedback for the email sent out after a user registers @jamesmrollins @hirenp-esquare.

jamesmrollins commented 1 year ago

Hi @lijenn and @ljmoody - Thank you very much for the thorough testing of the self-registration flow.

  1. @hirenp-esquare - please implement the suggestions above.
  2. @lijenn - regarding 7 above, yes, we may be working at the Sta3n level only, so a Sta6a code is not mandatory.
  3. @lijenn - regarding 13 above, yes, the approval email would go to mtl.how@va.gov.
  4. @hirenp-esquare feel free to reach out to any of us for clarification.

Thank you

lijenn commented 1 year ago

Discussed 7/14 with James:

Discussed 7/17 with Hiren, James, and Laura:

lijenn commented 1 year ago

To discuss with @jamesmrollins @ljmoody at 7/26 sim_ui_workflow meeting. @jamesmrollins to discuss with @hirenp-esquare

lijenn commented 1 year ago

DECISION: We are unable to address the screensharing issue for menu dropdowns using Mac Citrix. Likely due to a MS Teams screensharing issue.

lijenn commented 1 year ago

Identified at sim_ui_workflow 7/26 @hirenp-esquare @jamesmrollins need to discuss:

We confirmed Laura is an end-user in the Test instance too. image

lijenn commented 1 year ago

Hi @hirenp-esquare, please review @ljmoody and my feedback below.

    • [ ] Remove the space after the second underscore (blue circle)
    • [x] Prevent users from entering uppercase, only lower case (yellow highlights)
    • [x] Prevent users adding spaces, spaces should be underscores (red underlines) image

    • [ ] Can we make this pop-up automatically close after the user clicks submit OR grey out the button after the user clicks submit? image

    • [ ] Why is Laura automatically assigned the Facilitator role once she approves her registration? Did we want to assign first time users with the Member role @jamesmrollins?
    • [ ] After being approved and signing in, Laura does not see the team she registered for. image
ljmoody commented 1 year ago

Hi @hirenp-esquare, I have some feedback to incorporate into the Sim UI based on meetings with @lijenn and @jamesmrollins today:

in the Facilitator Dashboard:

image image

everywhere in the Sim UI:

image image
ljmoody commented 1 year ago

Hi @hirenp-esquare, two more things I noticed when in the Sim UI (I tried different browsers to see if that mattered, and it didn't.):

in the Facilitator Dashboard:

FYI: @jamesmrollins @lijenn

lijenn commented 7 months ago

Jenn and Laura have been completing the rest of QA in #3026 for Self-Registration. We can close this card since the work with Hiren has been completed.