lzim / teampsd

Team PSD is using GitHub, R and RMarkdown as part of our free and open science workflow.
GNU General Public License v3.0
9 stars 23 forks source link

2024_06 #story_l: Create a Test Checklist and Code Migration Procedure from 3.0 to 3.7 #2997

Closed jamesmrollins closed 3 months ago

jamesmrollins commented 1 year ago

@lzim Please validate the below

Condition

Definition of Done

jamesmrollins commented 8 months ago

FYI: @lzim @lijenn @ljmoody We need to discuss this and determine if and when we will do this. Test version release will do a link find-and-replace crawl through the entire repo through documentation we will likely not use in the new paradigm.

jamesmrollins commented 6 months ago

Context and Benefit Hypothesis

There are changes to the model directory structure in Epicenter that is supporting features in MTL 3.7 that are not in 3.0. 3.7 parses group team data into folders named after the group in the Model directory. This allows the Sim UI to limit the view of participants to only their group information. Furthermore, to maintain schedule, the PI is going to continue to build teams in 3.0. With these new and legacy teams, group team data files in 3.0 that will need to be migrated to the new structure. This mitigation strategy describes how the Sim UI Team will migrate from 3.0 to 3.7 while maintaining backwards compatibility.

Important Dates

Checklist:

jamesmrollins commented 6 months ago

3/25 Stand Up

ljmoody commented 6 months ago

Relevant question from @tejaspesquare to consider, decide, and respond to - see quoted comment below.

In V3.0 we don't have sub-folder concept & in 3.7 it has. We have to think of business rule to perform Delete action as because in current scenario file will be associated with individual group & possibly 2 or more groups will upload same name file but will have different locations. So, on delete which file supposed to be removed will cause for others. Could you please suggest.

image

Note: On this section we bring up (as per our conversation) all listed files from Epicenter. Also, we have filtered duplicate file if any.

ljmoody commented 5 months ago

Discussed at sim_ui_workflow 3/13/2024:

image

ljmoody commented 5 months ago

@lzim, please consider and provide guidance on:

lzim commented 5 months ago

@ljmoody Just checking: Are your questions on the right card re: MTL 3.0 to 3.7 migration?

Should deleting a Team Data file in a shared or team world also delete for all users in all shared/team worlds - or - just a specific world? Should uploading a Team Data file in a shared or a team world also auto-upload the file in team/shared world, too?

Unless there's something I'm missing...Yes and Yes for team and shared worlds. Individual worlds should operate separately. But do see my comment about uploading Team Data and admin access to that data file.

Let me know if this answers the relevant scenarios. Thanks!

lzim commented 5 months ago

@lijenn - Are we able to migrate the MTL 3.0 External Implementation Facilitation Manual to the new repo yet?

@lzim created these short URLs going to these link locations:

ljmoody commented 5 months ago

@lzim, Thanks for your input above re: Team Data uploads to team, shared, and individual worlds. I do believe this addresses what we needed to know. Yes, I meant for that question to be on this card, as it has to do with Epicenter file structures and, thus, the migration from 3.0 > 3.7. Definitely a consideration for Dev to know and keep in mind as we make this transition.

fyi: @lijenn, @jamesmrollins, @tejaspesquare

lijenn commented 5 months ago

@lijenn - Are we able to migrate the MTL 3.0 External Implementation Facilitation Manual to the new repo yet?

@lzim created these short URLs going to these link locations:

I'm having trouble copying over the GitHub Action workflows, I'll try it a different way. May be a token issue.

lijenn commented 5 months ago

Discussed at Sim UI Stand Up on 4/3/2024:

@ljmoody Just checking: Are your questions on the right card re: MTL 3.0 to 3.7 migration?

Should deleting a Team Data file in a shared or team world also delete for all users in all shared/team worlds - or - just a specific world? Should uploading a Team Data file in a shared or a team world also auto-upload the file in team/shared world, too?

Unless there's something I'm missing...Yes and Yes for team and shared worlds. Individual worlds should operate separately. But do see my comment about uploading Team Data and admin access to that data file.

  • [ ] If someone deletes a Team Data File in the shared or team world they are deleting it from shared and team worlds for all users of the shared and team worlds. This should not impact what is in individual worlds.
  • [ ] If someone uploads a Team Data File into a shared or team world, it should be available in team and shared worlds for all users of the shared and team worlds. This could be available in individual worlds too to save folks time. But, when someone uploads a Team Data file to an individual world, it should only be available to themselves and all MTL administrators who may need to provide support.

Let me know if this answers the relevant scenarios. Thanks!

lijenn commented 5 months ago

Discussed Sim UI Stand Up 04/03/2024:

@tejaspesquare will be able to make the bugs in Break Fix (e.g., #3131) once the migration from Prod to Break Fix is completed. Will reach out to us next week for migration updates.

lijenn commented 5 months ago

Discussed 4/7 Sim UI Stand Up:

tejaspesquare commented 5 months ago

@lzim , @ljmoody , @lijenn: Upload & Delete Team Data file (Settings -> Data) is developed & code is moved to Test Slow.

Below is my Testing results on Test-Slow. Group Name - test14march

Selecting _team file & Upload image

File got uploaded into world/team ( i.e. _ind, _shared & _Team) (Note: Checked file represents _team & _shared teams) image

Uploaded file is also accessible to a Team Member image image image

Delete file belong to _team & _shared Before Delete image

After Delete, only _ind file is present image

File is not available to a team member which was earlier accessible image image

lijenn commented 5 months ago

Discussed 4/10 Sim UI stand up:

jamesmrollins commented 5 months ago

3/14 Stand Up

jamesmrollins commented 4 months ago

5/5 Stand Up

lzim commented 3 months ago

sim_ui_workflow

@jamesmrollins @lijenn @ljmoody

Is this card done? thanks!