Closed ljmoody closed 7 months ago
@tejaspesquare Please see @ljmoody and my user test feedback below:
[x] 1. The user's selected VISN, Facility, and Clinic is missing in the team name pop-up:
For example, if the user selected VISN 19, Facility 554, and Clinic GJ, the highlighted yellow section should pre-populate: v19_554gj
The team name should always contain the VISN, Facility, and Clinic, in addition to the custom name the user inputs.
[x] 2. Delete the "at" in the Approval email:
[x] 3. The "Approve" button should be green.
[x] 4. The team name's VISN, Facility, and Clinic are missing.
[x] 5. In Shared worlds, change "Team" in the upper left hand corner to "Shared" so users know they are in the Shared world and not the Team world.
[ ] 6. All teams that register in the self-registration must show up users who have the administrative_login privilege. For example, Laura registered the team. But when Jenn logs in with her administrative_login, Jenn does not see the team:
Let us know if you have any questions!
Hi @tejaspesquare - thanks for giving a đź‘Ť so we know you see messages @lijenn and I post. We would like to test the self-registration process and documentation with users next week (on Nov 29).
Hello @ljmoody , @lijenn & @jamesmrollins - taken up this enhancement on priority & done top 5 points & it is available in Test environment. Regarding point #6, there is a dependency on API & we have sent query to David for his input. Hence, we will be able to give estimation (on #6) after getting response from David. Thanks!
@lijenn can you please elaborate on this point #6 - All teams that register in the self-registration. What exactly it means. How we can identify teams are registered as self-registration. From API (Epicenter) we don't have any bifurcation on type of teams. We shall proceed once this doubt is clear.
@tejaspesquare Users who have the administrative_login privilege should have access to any team that is set up or exists in the Sim UI (whether the user was added to the team or not).
For example, if a doctor created a team/world using the self-registration, anyone who has the administrative_login privilege should have access to the team that the doctor created. Assume that they did not add Laura and I to the team/world either.
However, because Laura and I have the administrative_login privilege, Laura and I could still access and see the doctor's team/world without being added as a member. This is in case the doctor has questions in the world/team, Laura and I can access it to help them.
This is the administrative_login:
Please let me know if you need more clarification and if we need to meet to talk about this!
@lijenn Thank you for detailed response. I think it answered now. Whoever is logged in with administrator_login world will be able to see entire list of teams available in SIM UI.
Here self registration follows for this step, correct? Or do we have a separate self registration portal exist & I'm not aware? i.e. Login -> Register for First Time
@tejaspesquare Yes! That screen is the self-registration process.
@tejaspesquare Laura and I got to test with members on our team, here's more feedback.
Note for point 6: I believe the feature was working before Hiren left. So there may just be a bug somewhere/unsure why the feature stopped working.
[x] 7. Add a blank/empty selection as the default selection for each VISN's Clinic field.
The Clinic field is optional so users do not have to select a Clinic. For example, if a user selects VISN 21 and Facility 640, the Clinic field should have a blank/empty field as the default. Note: If a user does not select a Clinic, their team name would exclude the Clinic. Example: v21_640_jennifers_team_name
[x] 8. There should be no underscore between the Facility and Clinic in the team name. Append the selected Clinic directly after Facility. So this pop-up below should be: v21_640hc
[x] 8. Add the subtext "Must contain at least 1 number" underneath "New Password" and "Repeat Password". Use the same font and font size as the "Sta3n" and "Sta6a" text.
[x] 9. Change wording from "Select Facility Team" to "Select Or Create A Facility Team".
[x] 10. Change wording from "Enter your facility team name" to "Complete Your Facility's Team Name".
[x] 11. Add the subtext "Our team naming convention uses all lower-case and underscores. For example: v21640a0 mpd_green_bhip" underneath "Enter your facility team name". Use the same font and font size as the "Sta3n" and "Sta6a" text.
[x] 12. Missing underscore after the Clinic in the team name pop-up
[x] 13. Previously created/existing teams are not showing up. I created 1 team using the same VISN, Facility, and Clinic and could not find it in the dropdown:
[x] 14. Change "Your registration has been forwarded to the Approver." to "Your registration has been forwarded to MTL for approval." Use the same font and font size as the "Sta3n" and "Sta6a" text.
[x] 15. Hide the Shared world for all users that do not have the administrative_login privilege. Only users who have the administrative_login should be able to see all the registered teams, ind, and shared worlds.
These 2 errors occurred in the team, shared, and individual worlds for users who registered using the self-registration form .
[x] 16. The Delete and Upload button do not work.
[ ] 17. Users, except for administrator, should not be able to see all the existing data files in the Sim UI. We do not want users to be able to access and view every single data file from other people and clinical teams uploaded in the Sim UI. Users can see data files based on the group (_team, _ind, _shared) they are assigned or added to.
They should just see the data files they:
A) choose to Upload (using the Upload button) and
B) the list of data files that an administrator_login user adds into their world
@lijenn 1.Point 7 & 8 - We have added additional drop-down value under clinic as 'select' so that it will work according to notes for Point 7 & 8. Otherwise, it will have one clinic value default selected.
2.Point 15 - It required to analyze existing code which allow us to filter shared worlds who do not have administrator_login privilege.
3.Point 16 - Delete & upload button works for us.
After Delete
4.Point 17 - It required to investigate functionality & possibility to filter records based on self registered users. Need to find API support this.
@lijenn Development on points 7 To 14 is completed & available on dev environment. I will check with James if we can proceed to deploy on TEST-Slow.
Hi @tejaspesquare - is there an update on when you might deploy the changes to TEST-Slow? If possible, I'd like to take new screenshots and incorporate into the documentation before our test training session this Thursday.
FYI - @lijenn
@ljmoody Changes are moved to test. Kindly verify & let us know your comments. Note: Please ignore Flow Meter of 'Team Flow'. Kept on hold & suggest if required to hide it. Sincerely apologize for any inconvenience.
Hi @tejaspesquare. Please incorporate the comments below on self-registration windows and popups:
[x] 1. On the self-registration form, please uncapitalize the O and A (highlighted in yellow); I missed that detail before:
[x] 2. On the first person to register popup:
Change "lower-case" (highlighted in yellow) to "lowercase"
Please remove the space (highlighted in yellow) in the example given so it reads: "v21_640a0_mpd_green_bhip"
[x] 3. The popup approver message I'm seeing is still the same. From point 14 above, change "Your registration has been forwarded to the Approver." to "Your registration has been forwarded to MTL for approval." Use the same font and font size as before, don't change the font/size to the "Sta3n" and "Sta6a" text.
[x] 4. In the approval email, please (highlighted in yellow):
change T to lowercase
change the comma to a period:
@lijenn - FYI
@ljmoody @lijenn - Point 3 (5th Dec communication) - Popup approver message working fine. Not sure why it is not reflected on your side. Do clear cache & delete histories may fix issue automatically.
@ljmoody @jamesmrollins @lijenn - Regarding Point No 17. 'Users who registered using the self-registration form should not be able to see all the existing data files in the Sim UI. We do not want users to be able to access and view every single data file from other people and clinical teams uploaded in the Sim UI.'
Actually, we were looking for API which retrieve list of data files uploaded by self registered user & based on results we can differentiate file uploaded by self registered user or administrator_login user. Current API response details is not enough so we contacted David for the same & received response as below:
"The project file system is, unsurprisingly, backed by a file system. The owner of that file system is necessarily the entity executing file operations, which is epicenter. Neither your users nor anyone else’s holds an actual user account as far as the file system is concerned, so we have no way to provide that information. However, if you’re making the api calls, I would guess you do, and could keep a history, or shadow file information. You would need a convenient data storage system for that kind of information. We do provide the vault api for just this sort of usage. It is a storage system for loosely structured data of your choosing (actually a json store, actually backed by mongodb). The vault api…
https://forio.com/api/v3/account/project/encyclopedia/as/asciidoc_to_html/v3/vault
…can be complex, but utilizes the same building blocks as the rest of the v3 api, such as scope and permit. Proper usage takes some thought and planning, as does the proper usage of any data store, towards capabilities and long term data evolution. "
So, at this moment we (Ask EHS Team) are unsure about efforts & possible solution however we can give a try when time permits.
Hi @tejaspesquare. I'm sorry about this:
@ljmoody - Can't access attachments. Could you please reshare it for our reference.
I've revised the attachments and my comments in the post above. Clearing the cache did change some things; thank you for suggesting that and being patient.
I can confirm that this message is corrected now:
@ljmoody @lijenn - Point 3 (5th Dec communication) - Popup approver message working fine. Not sure why it is not reflected on your side. Do clear cache & delete histories may fix issue automatically.
Hi @tejaspesquare. Please incorporate the comments below on self-registration windows and popups:
- [x] 1. On the self-registration form, please uncapitalize the O and A (highlighted in yellow); I missed that detail before:
- [x] 2. On the first person to register popup:
- Change "lower-case" (highlighted in yellow) to "lowercase"
- Please remove the space (highlighted in yellow) in the example given so it reads: "v21_640a0_mpd_green_bhip"
- [x] 3. The popup approver message I'm seeing is still the same. From point 14 above, change "Your registration has been forwarded to the Approver." to "Your registration has been forwarded to MTL for approval." Use the same font and font size as before, don't change the font/size to the "Sta3n" and "Sta6a" text.
- [x] 4. In the approval email, please (highlighted in yellow):
- change T to lowercase
- change the comma to a period:
@lijenn - FYI
@ljmoody - Above changes are moved to TEST-Slow environment.
Thanks @tejaspesquare! Here's the latest feedback. We're almost there!
[x] 18. Change "Register for First Time" to "Create Account or Team"
[x] 19. Change "Create an Account or Team"
[x] 20. When selecting a Clinic/Sta6a, the existing teams for that Clinic/Sta6a do not show up in the "Select or Create a Facility Team" dropdown:
[x] 21. For the subtext underneath: Complete Your Facility's Team Name
Move "For" to the next line so "For example: v21..." is all on the same line.
Increase the font size by 1 or 1.5x
Bold the words "lowercase", "underscores", and "For example: v21_640a0_mpd_green_bhip".
Remove the parentheses
[x] 22. In the approver page, rename "Return" to "Reject".
[x] 23. In the Return/Reject email, please follow this template:
Dear Jennifer,
Sorry! We had trouble registering your account or team.
Please use our team naming convention for your team name:
Need more help? Email: MTL.Help@va.gov (note to dev: please hyperlink the MTL.Help@va.gov email)
Go back to the sign up page here. (note to dev: use the link currently in "Go Back" in the old email template and put it in "here" in the new template).
Thanks! Modeling to Learn (note to dev: please italicize "Modeling to Learn" and "Need more help?")
[x] 24. Change the colon to a period in the approval email. Unbold the "Thanks".
[x] 25. Remove "Facilitator" in the successful registration email. Turn the comma into an exclamation mark. Unbold the "Thanks".
[x] 26. When the screen is loading after clicking the green "GO!" button, include quick tips while the page is loading:
For example, here's a random quick tip after I click "Play":
All quick tips are located here:
FYI @ljmoody, recommended some new language above, so screenshots might need to change. Lmk if you need help with that!
@lijenn - From latest list change pending for Point no 26 (quick tips). Rest all points are moved to TEST-Slow. Point 20 - We have not made any change. Can you please check once if it is working or not
Hello @tejaspesquare ,
Hello @tejaspesquare ,
- Please italicize MTL in the popup message below:
@ljmoody - This is updated & can be verified in TEST-Slow.
Hi @tejaspesquare Laura and I do not see the MTL being italicized in the popup yet. I checked in both TEST-Slow and Dev but I still see this:
Hi @tejaspesquare Laura and I do not see the MTL being italicized in the popup yet. I checked in both TEST-Slow and Dev but I still see this:
@lijenn - Now, it should work. Merge was pending on GitHub. Sorry for inconvenience.
Hi @tejaspesquare Any updates on 15, 16, and 26?
Hi @tejaspesquare Any updates on 15, 16, and 26?
@lijenn - Please see my response below Point 15 - Team will be focused on Casual Loop Diagrams till 18th or 19th. After this they will start looking into Vault API stuff for which we got response from David on our query for filter worlds. Point 16 - Its working on our end. Can you please check again if its working or not. Point 26 - This will be available to you by 19th or 20th Dec.
Thanks!
Hi @tejaspesquare. @lijenn and I had a Sim UI test session today. We're following up with the following:
Is there an update for Point 15?
- Hide the Shared world for all users that do not have the administrative_login privilege. Only users who have the administrative_login should be able to see all the registered teams, ind, and shared worlds.
Is there an update for Point 26?
- When the screen is loading after clicking the green "GO!" button, include quick tips while the page is loading:
New request:
Hi @ljmoody -
Hi @tejaspesquare, for 26. quick tips, I do not see it in Test-Slow yet:
Hi @lijenn : Point 26 - Thank you for notify. This is resolved now & moved to Test-Slow.
Hi @tejaspesquare and thank you for your updates. I verified that:
Point 26, adding quick tips, is now functional:
Point 27, font is enlarged:
FYI @lijenn
Hi, @tejaspesquare James let us know you're making progress on the API issue. Do you have any further updates for us?
@ljmoody - We are coordinating with Daivd. So far, we have successfully inserted sample data through vault API. Now, we will look into how actual objects need to bind & save using Vault API.
@ljmoody , @lijenn - Point 15. Hide the Shared world for all users that do not have the administrative_login privilege. -> This is moved to TEST-Slow. Kindly test & provide your feedback. Note: At moment have verified with self-registered accounts.
Jenn and Laura have completed testing, so we are closing this card. Point 17 remains, and is being tracked as a bug under #3091.
Laura and Jenn test the facility self-registration at https://mtl.how/test.
To test 2/15: