Open ljmoody opened 7 months ago
fyi: @jamesmrollins @lijenn @tejaspesquare
~- [ ] 2. Ending Service Rate vs Ending Rate - awaiting Lindsey's feedback in #3199 before knowing which label to amend: ~
~- [ ] 3. Start Rate vs Starting Rate - awaiting Lindsey's feedback (as above) before knowing if these labels may need to be amended.~
Hello @ljmoody
PSY- Modifications have been done and are now accessible on the testing environment for validation.
Feedback for PSY Flow Diagram:
- Numbers populated correlate with what I see in the simulation so I believe the flow diagram is behaving as expected.
- [x] 1. Change "appts" to "pts", 4 locations:
- [x] 4. Capitalize "d" in "during" (highlighted):
@tejaspesquare, please incorporate the following:
[x] Change highlighted text to: "Ending Rate"
[x] Discussed with @jamesmrollins at Team Praxis meeting today: With 0.23 in and 0.23 out (as shown on graphic), it doesn't appear to meet the logic requirement needed for the stock to show as red. Is it possible to change the computation to consider 3 significant digits to determine the stock color? Would that work for this example - or would it still be computing as "less than or equal to" the output number?
Hello @ljmoody
Required changes being made & available on TEST.
- [x] Change highlighted text to: "Ending Rate"
- [x] Discussed with @jamesmrollins at Team Praxis meeting today: With 0.23 in and 0.23 out (as shown on graphic), it doesn't appear to meet the logic requirement needed for the stock to show as red. Is it possible to change the computation to consider 3 significant digits to determine the stock color? Would that work for this example - or would it still be computing as "less than or equal to" the output number?
Note: We have not considered 3 digits for computation, it remain same for 2 digits.
✅ verified:
@tejaspesquare, so I better understand, did you make an adjustment to the logic that made the stock color change? It's correct now. And just like in the example I posted, the numbers in and out are equal. So I'm wondering what made the difference.
Hello @ljmoody ,
Please verify on TEST.
@tejaspesquare, so I better understand, did you make an adjustment to the logic that made the stock color change? It's correct now. And just like in the example I posted, the numbers in and out are equal. So I'm wondering what made the difference.
Variable conversion is implemented in one of the code blocks. Previously, the variable had more than 5 decimal digits, leading to an unexpected outcome.
- [ ] Noticed a misspelling when looking at the CC Flow. Please change to "Appointments": Psy
@tejaspesquare - thanks for explaining the stock color variable conversion. I tried to verify above change today, but flow does not appear in TEST:
So I tried DEV, but it's not there either:
Please let me know when it's back in the Sim and I'll test then.
Hello @ljmoody ,
Apologize for any inconvenience caused. This feature is enabled for CC, MM, and PSY on TEST.
CC
MM
PSY
wk4 2024_07 - @lzim reviewing Flows across modules https://github.com/lzim/teampsd/issues/3199 CC & MM https://github.com/lzim/teampsd/issues/3204 Team Care (AGG) https://github.com/lzim/teampsd/issues/3205 Team Flow (SP)
#sim_ui_workflow @matomasz @lijenn @ljmoody @jamesmrollins @tejaspesquare
@tejaspesquare - following up on this card. Do you have an update for us or rough ETA for when we can test?
Discussed at 8/9/24 Team Praxis meeting:
We need a message to clarify. how to interpret color stock indicators
- [ ] Recommend a color key that with this text below Red = Inflow > Outflow Blue = Outflow > Inflow
week 3 2024_08 Praxis Meeting @matthewtomo @jamesmrollins @ljmoody
Hi Matthew
- @tejaspesquare do we have the go ahead to test the PSY flow meters? AND Is it available for testing in the TEST environment?
The PSY flow meter is currently available for testing, excluding the changes to the color stock indicator and the dynamic flow size (height), which will be available after receiving confirmation for the MM model changes (#3204).
Discussed Dev Standup wk4 2024_08 @matthewtomo @tejaspesquare
All TEST cards for Flow:
3199 CC & MM
3072 PSY
3204 Team Care (AGG)
3205 Team Flow (SP)
AC:
[ ] all feedback to DEV is addressed and/or incorporated
~- [ ] When the user clicks on the "Flow" icon from the Dynamic Decision Dashboard, the user is presented with a new browser tab with the diagram depicted in the wireframe.~