Make issues.Client.LabelIssue() idempotent for delete.

m-lab / alertmanager-github-receiver

Prometheus Alertmanager webhook receiver that creates GitHub issues from alerts

Apache License 2.0

48 stars 23 forks source link

Make issues.Client.LabelIssue() idempotent for delete. #40

Closed cjyar closed 4 years ago

cjyar commented 4 years ago

This is a fix for my previous PR #38 which incorrectly assumed that the GitHub API was idempotent. It is actually idempotent for label add, but not for label delete.

This change is

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 128

11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 127:	0.0%
Covered Lines:	378
Relevant Lines:	378

💛 - Coveralls

cjyar commented 4 years ago

Tested on a real system. ;) Seems to work.