m-lab / go

General purpose libraries / APIs for use in mlab code.
Apache License 2.0
5 stars 6 forks source link

Simplify visit parameters, handle all errors #71

Closed stephen-soltesz closed 5 years ago

stephen-soltesz commented 5 years ago

This change simplifies the parameters for the visit callback passed to WalkSchema and correctly handles an error case previously ignored.


This change is Reviewable

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 593


Changes Missing Coverage Covered Lines Changed/Added Lines %
bqx/schema.go 13 15 86.67%
<!-- Total: 13 15 86.67% -->
Totals Coverage Status
Change from base Build 590: -0.08%
Covered Lines: 845
Relevant Lines: 1026

💛 - Coveralls
pboothe commented 5 years ago

Please don't add uncovered lines. You don't need to clean up the campsite, but please don't leave it worse than you found it :)

stephen-soltesz commented 5 years ago

This did not go how I imagined :)

I'll address comments relevant to the original files in a separate PR.