search

m19c / gulp-run

Pipe to shell commands in gulp
ISC License
151 stars 25 forks source link

Drop dependency on deprecated `gulp-util` #54

Closed TheDancingCode closed 3 years ago

TheDancingCode commented 6 years ago

Closes #53

line0 commented 6 years ago

Nope, this is not yet good enough. gulp-run still depends on vinyl 0.4.6, which (from what i gathered) caused the whole ordeal first place. It's also possible that the vinyl test fails for that very reason. I haven't tried yet, but upgrading to vinyl 2.1 might fix the issue.

m19c commented 6 years ago

I agree with line0. I would suggest the following: we find out if vinyl is the problem - if so, we should try to update the dependency. If that does not solve the problem, we can consider making a new major release for gulp-run.

FizzyGalacticus commented 6 years ago

I just tried to look into this, and I found that the current master branch is failing tests as well.

image

TheDancingCode commented 6 years ago

The goal of this PR is not to fix issues you previously might have had with your plugin. It simply replaces a deprecated utility package by a functionally equivalent but smaller one. If the tests were failing before, they still will do so now, but the problem is unrelated to the PR or the changes it proposes.

I don't know the inner workings or the history of your package, so I'm not sure what the 'whole ordeal' is that you're referring to. So if this is 'not yet good enough', I'm afraid I can't help out any further. But once again, this PR is not trying to fix any and all problems you have with your plugin.

FizzyGalacticus commented 6 years ago

The "while ordeal" he's referring to is that the outdated vinyl package is the cause of gulp-util breakage.

FizzyGalacticus commented 6 years ago

Here's a reference to why gulp-util is breaking packages in gulp v4: https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5

TheDancingCode commented 6 years ago

Any progress on this?

2martens commented 4 years ago

Is there any update over two years later?