Applying sbt-scalariform 1.6.0

m3dev / octoparts

Octoparts, the backend services aggregator

https://m3dev.github.io/octoparts/

Other

151 stars 18 forks source link

Applying sbt-scalariform 1.6.0 #201

Closed seratch closed 7 years ago

seratch commented 7 years ago

This pull request contains the following changes.

bump sbt-scalariform version to 1.6.0 (latest)
apply scalariform with the rules defined in project/Scalariform.scala
apply scalariform to not only Play app but also other sub-projects as well
manually modify some code to make them more readable

I believe the changes improve the readability of code.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 82.856% when pulling 1cbae574b896dcb643acbe38d56b397efc3308e0 on seratch:bump-scalariform into 49c1381cb302018f0d045a819bc1093fe6a00cc6 on m3dev:develop.

btakashi commented 7 years ago

I think it's an issue with the Scalariform settings that existed from before (and maybe were not applied?), but I'm not a fan of alignParameters (i.e. lining up = signs and types), it looks unusual to me (probably because false is the default). I think this is mostly a matter of preference, although I would argue that the default probably looks more typical / expected to most people.

seratch commented 7 years ago

scalariform sometimes changes its default rules. I guess the many diff were basically brought by the changes on default ones. Anyway, I'll try to optimize the existing rules.

btakashi commented 7 years ago

Thanks!

seratch commented 7 years ago

Updated. Eventually, I decided to stop using all the existing overwritten rules and believe applying scalariform's default rules is the best also for this project. Basically, I use scalariform's default on my OSS projects and it always works fine.

Additionally, I've improved the readability to refine too long lines. As discussed above, I didn't change the argument parts that have lots of swagger-related annotations.

I'll work on further changes that depend on this pull request.

coveralls commented 7 years ago

Coverage decreased (-1.02%) to 81.677% when pulling c64219ae249bb0dd29d4ac53e7f2c9d110deed89 on seratch:bump-scalariform into 49c1381cb302018f0d045a819bc1093fe6a00cc6 on m3dev:develop.

coveralls commented 7 years ago

Coverage decreased (-1.09%) to 81.472% when pulling 54b085cf9c3c17385061e652ada4da6663de6446 on seratch:bump-scalariform into e7970665c252811a32f0c9a5bbf1ccc6c1549126 on m3dev:develop.

seratch commented 7 years ago

@bloodysnowx Rebased. Still any concerns on this?