m42e / certbot-dns-ispconfig

A certbot plugin for enabling DNS authentication with ISPConfig
Other
28 stars 16 forks source link

pip installer uses older version #12

Open RikshaDriver opened 2 years ago

RikshaDriver commented 2 years ago

The pip install contains an older version which causes datetime errors when attempting to use.

The instance needs to be updated to reflect the latest GitHub version

rasos commented 1 year ago

I can confirm that with ISPconfig 3.2.9p1 you need to copy the latest version of the repo, else you get an error like

API response with an error: Incorrect datetime value: '' for column dbispconfig.dns_rr.stamp at row 1 INSERT INTO dns_rr (server_id, zone, name, type, data, ttl, active, stamp, serial, sys_userid, sys_groupid, sys_perm_user, sys_perm_group, sys_perm_other) VALUES ('2', '201', '_acme-challenge', 'TXT', 'OrakjhsdflkhsdfU0R8YpBpK5Am70987kzmWYPU', '60', 'Y', '', '0', '1', '1', 'riud', 'riud', '')

ahrasis commented 1 year ago

Please note that using snapd to get the latest fully functional certbot is the best way for now. Do remove all old certbot installations from your ISPConfig system / server before reinstalling certbot using snapd.

lcx commented 3 months ago

This still seems to be an issue which causes problems with nginx-proxy-manager. Are there plans to make the new version with fix installable through pip install?

rabesocke commented 1 month ago

There is a new version of the certbot-dns-ispconfig plugin.

https://pypi.org/project/certbot-dns-ispconfig/