search

m4b / goblin

An impish, cross-platform binary parsing crate, written in Rust
MIT License
1.17k stars 156 forks source link

pe: Attribute certificate revisions are non-exhaustive #378

Closed RaitoBezarius closed 10 months ago

RaitoBezarius commented 10 months ago

Excerpt of https://learn.microsoft.com/en-us/windows/win32/debug/pe-format

The options for the WIN_CERTIFICATE wRevision member include (but are not limited to) the following.

Emphasis mine.

m4b commented 10 months ago

NB: breaking change

RaitoBezarius commented 10 months ago

Yes, for us, it fixes a bug I introduced in https://github.com/nix-community/lanzaboote where we were not able to read PE anymore with the latest Goblin version.

m4b commented 6 months ago

released in 0.8.0, happy new year!