m4ss1m0g / mediatr-ts

Mediator patter for Typescript, inspired to MediatR csharp library
MIT License
50 stars 10 forks source link

Rewrote docs, added behaviors and more #9

Closed ffMathy closed 1 year ago

ffMathy commented 1 year ago

I want to use this package in my work (I work for a corporation). However, for that to happen, I think these things that I propose here should be fixed. Alternatively I think I will make a fork at some point.

It's a big one. I hope it's okay, and that you can find the time for looking into it 🙏

Documentation

Notification handlers

Dispatcher

Pipeline behaviors

Boyscouting

Miscellaneous

ffMathy commented 1 year ago

cc @m4ss1m0g (in case you don't get notifications for this kind of stuff).

m4ss1m0g commented 1 year ago

@ffMathy You have done great work! Can you also update the CHANGELOG with these new improvements?

m4ss1m0g commented 1 year ago

Close the #5

ffMathy commented 1 year ago

Thanks for merging! However, I realized I forgot to follow the "keep a changelog" format, so I actually made an additional commit after. See #10 now.

Sorry about that!

m4ss1m0g commented 1 year ago

@ffMathy. No problem. However, you must increment 1 the patch level of packages.json, 1.0.1 otherwise I can't publish the package

ffMathy commented 1 year ago

I think it's actually okay to not publish the package, as only CHANGELOG.md has changed, which is not actually part of the package. Do you agree?

m4ss1m0g commented 1 year ago

In this case, the PR remains open, otherwise, if I merge it tries to publish and returns an error.

m4ss1m0g commented 1 year ago

I think is better to merge.

ffMathy commented 1 year ago

Awesome stuff ❤️ thanks once again.

More improvements will come, but I don't know when.

For instance, I'd like to throw an exception if the settings get mutated after they've been used once.

That way, we can tell the user if they are mutating settings after load.