search

macchiato-framework / macchiato-core

Ring style HTTP server abstraction for Node.js
MIT License
377 stars 35 forks source link

"Buffer() is deprecated due to security and usability issues" in macchiato.middleware.session.cookie #41

Closed theasp closed 4 years ago

theasp commented 4 years ago 
(node:12627) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

See: https://nodejs.org/en/docs/guides/buffer-constructor-deprecation/

yogthos commented 4 years ago

Thanks for the heads up, any chance you could do a PR for this? :)

jdhorwitz commented 4 years ago

I will take a look at this one as well. Thanks @theasp .

jdhorwitz commented 4 years ago

This looks like it was fixed with https://github.com/macchiato-framework/macchiato-core/commit/1144c9e2f5f91e7d390bb38f751810e295388332 After @yogthos confirms, I think we can resolve this one.

yogthos commented 4 years ago

Yup, that does look like it's been fixed.