search

macformula / racecar

Monorepo for all firmware running on our custom ECUs.
https://macformula.github.io/racecar/
9 stars 3 forks source link

Update to clangd 18 #93

Open BlakeFreer opened 7 months ago

BlakeFreer commented 7 months ago

Currently we require v16.0.2 as v17 introduced a change that broke support for parsing response files in compile_commands.json. These .rsp files are generated by CMake on windows, and thus clangd 17 does not work when windows builds for itself

Task: Wait until clangd 18 has binaries released, test them, and if everything works then update our version spec in firmware/readme

As of April 4, 2024, v18.1 is available on GitHub as source code, but binaries have not been released yet

BlakeFreer commented 3 months ago

Wow 18.1.3 binaries were released literally the next day https://github.com/clangd/clangd/releases/tag/18.1.3

There still seems to be an error. On windows, I need the 

CompileFlags:
  Add: --target=x86_64-w64-mingw64

configuration in .clangd to allow clangd to find the system headers, but this emits a "invalid option -mcpu for target x86_64..." when compile commands comes from an stm32 build.

This issue is not present in 16.0.2 so let's stay with it for now. Or, if you find a better solution, make a PR.