machine-drivers / docker-machine-driver-xhyve

docker-machine/minikube/minishift driver plugin for xhyve/hyperkit (native macOS hypervisor.framework)
https://godoc.org/github.com/machine-drivers/docker-machine-driver-xhyve
BSD 3-Clause "New" or "Revised" License
888 stars 74 forks source link

Fix vbox ver 4 detection #214

Closed pauliusm closed 5 years ago

pauliusm commented 5 years ago

Fix version detection so docker-machine would work with VirtualBox 6.

pauliusm commented 5 years ago

Test is broken because of ocaml...:

# Run eval $(opam env) to update the current shell environment
The following dependencies couldn't be met:
  - io-page → ocaml < 4.06.0
      base of this switch (use `--unlock-base' to force)
No solution found, exiting
The command "opam --version && opam init && opam install uri qcow-format io-page.1.6.1 ocamlfind conf-libev" failed and exited with 20 during .
LeoUfimtsev commented 5 years ago

I ran into this issue today (I'm running Virtualbox 6). Would be nice to see it merged.

praveenkumar commented 5 years ago

@pauliusm Can you check the CI failure?

pauliusm commented 5 years ago

@praveenkumar CI failure is not connected with my patch, it's most probably problem with ocaml packages:

# Run eval $(opam env) to update the current shell environment
The following dependencies couldn't be met:
  - io-page → ocaml < 4.06.0
      base of this switch (use `--unlock-base' to force)
No solution found, exiting
The command "opam --version && opam init && opam install uri qcow-format io-page.1.6.1 ocamlfind conf-libev" failed and exited with 20 during .
Your build has been stopped.
LeoUfimtsev commented 5 years ago

Thank you for merge. Do you guys have any idea in what version of minishift this fix would be available?

dhergert commented 5 years ago

This isn't a minishift issue, it's a xhyve issue. Minishift doesn't ship with xhyve, you probably downloaded and installed it with brew, ie brew install docker-machine-driver-xhyve

My version shows as "0.3.3_1" which was released 2 years ago. I guess the question for @praveenkumar is when do you think a new xhyve release will be cut with this fix? Virtualbox 5.2 goes unsupported in 18 months and 6.0 has been out for quite some time now.

Thanks!

praveenkumar commented 5 years ago

@dhergert I am try to do a release soon for this fix, since this is going to impact lot of folks.

kalbasit commented 5 years ago

@praveenkumar this is impacting a lot of people, can you please cut a release?

yackermann commented 5 years ago

@praveenkumar Same thing here. When are you guys planing to release?

kalbasit commented 5 years ago

@zchee @SvenDowideit @pecigonzalo @LalatenduMohanty @gbraad Please either cut a release soon or mark this project as dead so we can fork it and move on. It's very frustrating to keep having to ask people to uninstall VirtualBox on their Macs.

zchee commented 5 years ago

@kalbasit sorry for late. will cut new release version asap

kalbasit commented 5 years ago

:tada:

@zchee Thank you! You'll probably want to also close out #220 in that case! :beers:

zchee commented 5 years ago

@kalbasit Released v0.4.0 https://github.com/machine-drivers/docker-machine-driver-xhyve/releases/tag/v0.4.0

zchee commented 5 years ago

@kalbasit Thanks for mentioned, just closed with comment 🙇‍♂️

yackermann commented 5 years ago

Ref https://github.com/Homebrew/homebrew-core/pull/39939

zchee commented 5 years ago

@herrjemand also Thanks :)

kalbasit commented 5 years ago

@zchee many many thanks!! @herrjemand wow, that was fast! Thank you very much for that @chenrui333!

IDCS1426 commented 4 years ago

You fix here, you break there. Using 0.4.0 lead to

Error starting the VM: Error creating new host: json: cannot unmarshal bool into Go struct field Driver.Virtio9p of type []string

You use 0.3.3 you get

Error creating the VM. Error with pre-create check: Virtual Box version 4 or lower will cause a kernel panicif xhyve tries to run. You are running version: 6

condescendent commented 4 years ago

You fix here, you break there. Using 0.4.0 lead to

Error starting the VM: Error creating new host: json: cannot unmarshal bool into Go struct field Driver.Virtio9p of type []string

You use 0.3.3 you get

Error creating the VM. Error with pre-create check: Virtual Box version 4 or lower will cause a kernel panicif xhyve tries to run. You are running version: 6

HI, guys, I have gotten the same dilemma and have spent hours to get a solution. Could anyone help me with this ? I am using 0.4.0 and would like to get a fix for this newest version. Anyone can kindly help me with this ?

IDCS1426 commented 4 years ago

@condescendent Got it work on MacOS using xhyve