search

machulav / ec2-github-runner

On-demand self-hosted AWS EC2 runner for GitHub Actions
MIT License
747 stars 337 forks source link

Allow providing ec2-instance-count to start multiple runners #165

Closed dexbleeker closed 6 months ago

dexbleeker commented 1 year ago

Fixes #8

This PR is based on the fork of @messense, specifically this commit.

It allows for providing ec2-instance-count as input variable and will start multiple runners if desired. By default 1 runner is started.

Note that this might not be the cleanest code or best implementation. I don't write JS generally and have not touched a GH action before. Especially Array.from(JSON.parse(ec2InstanceIds)) feels wrong.

All feedback is welcome however.

mickmorse commented 1 year ago

Works like a charm

@machulav 👀

mickmorse commented 1 year ago

Only comments are to update the readme surrounding the outputs and examples (with it now being ec2-instance-ids)

wu-json commented 1 year ago

Any plans to merge this?

Dmitry1987 commented 11 months ago

MinCount/MaxCount are not used anywhere, shouldn't it be a specific count, why there's a min/max, kind of "if at least N will successfully be created" ? a useful feature for me too, i wonder why won't be merged :(

thimios commented 8 months ago

+1 Very useful feature for us too.