macjabeth
commented
6 years ago Why did you make
link.setAttribute('contenteditable', true);contenteditable true to the active anchor links ?
It's there so that if the user wants to move to a specific page, they can do so. You just click on the active element and then enter a new page number.
I have put a simple dark theme for now with a white banner so that the image in the header appears prominently.
I'm going to have @BabyMaybe take a look at this as he's the styling wiz for this project.
But looking over it a bit myself, I like the shade you chose; however, I think a few necessary changes need to be added before merge:
- Both the header and search container / input form should blend in with the darker theme colour. For example:
The banner image may be dark at the moment, but we could always add another banner in the future that contrasts well with the dark background, like an orange vampire-bunny or something. 🤔 - When clicking on a movie or show to bring up the dialog, there's no dark theme for the dialog, it's still all white and should have a similar dark colour to fit with the theme.
- The same goes for the transition animation when someone clicks the "Stream Now" button.
- This isn't required, but if you feel like going the extra mile, adding in a method to toggle between the light and dark theme would be greatly appreciated. 😃
Jayadev6191
@macjabeth I have put a simple dark theme for now with a white banner so that the image in the header appears prominently.
I saw something interesting in the js file while setting the pagination. Why did you make
link.setAttribute('contenteditable', true);contenteditable true to the active anchor links ? Just curious :)