Closed Bassadin closed 3 years ago
This is like my second PR ever, feel free to scold me if I did something wrong :)
Hey @Bassadin! Thanks for the PR. 🙂
I'll take a look at this during my live stream tomorrow.
@Bassadin Hey. I tried to merge the conflicts and push up to your branch, but I'm unauthorised unfortunately.
So I'm going to just merge these changes in directly and push them up to the rebirth branch. Thank you for doing this PR!
Oh. Any chance what I can do to avoid that next time? I think I I used gitkraken to create the branch, I thought the original owner of the repo always has some kind of access to each fork.
Oh. Any chance what I can do to avoid that next time? I think I I used gitkraken to create the branch, I thought the original owner of the repo always has some kind of access to each fork.
Hey @Bassadin - check out this link for the future. 🙂
"Allowing changes to a pull request branch created from a fork - GitHub Docs" https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork
Thanks for the link :) Did you talk about the issue during your stream? I skipped through it a bit but couldn't find it :o
Thanks for the link :) Did you talk about the issue during your stream? I skipped through it a bit but couldn't find it :o
I'm afraid not. I was planning to but decided to switch gears after reviewing the first PR. Perhaps next time though!
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/macjabeth/showbunny/Eu9jdbEQUjMojKL7YTg2XURUt4wp
✅ Preview: https://showbunny-git-fork-bassadin-rebirth-macjabeth.vercel.app