macxred / pyledger

Python package to streamline the implementation and management of accounting systems.
MIT License
0 stars 0 forks source link

Feat: create memory ledger #19

Closed AlexTheWizardL closed 1 month ago

AlexTheWizardL commented 2 months ago

This PR covers changes of creating the MemoryLedger class, which extends StandaloneLedger to create a non-persistent ledger system.

This PR is better reviewed commit by commit:

@lasuk Please review the changes and provide feedback or approval for merging

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 90.22989% with 17 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pyledger/memory_ledger.py 91.20% 8 Missing :warning:
pyledger/ledger_engine.py 89.70% 7 Missing :warning:
pyledger/standalone_ledger.py 81.81% 2 Missing :warning:
Flag Coverage Δ
unittests 64.62% <90.22%> (+6.20%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pyledger/__init__.py 100.00% <100.00%> (ø)
pyledger/constants.py 100.00% <100.00%> (ø)
pyledger/test_ledger.py 100.00% <100.00%> (ø)
pyledger/standalone_ledger.py 69.64% <81.81%> (+0.55%) :arrow_up:
pyledger/ledger_engine.py 65.43% <89.70%> (+6.01%) :arrow_up:
pyledger/memory_ledger.py 91.20% <91.20%> (ø)
lasuk commented 1 month ago

Thanks for the final modifications. Ready to merge ...

It's a pleasure to see our concept implemented. Quite convincing!