FOV in deg instead of rad.

mad-lab-fau / BASH-Model

We developed a method animating a statistical 3D human model for biomechanical analysis to increase accessibility for non-experts, like patients, athletes, or designers.

Apache License 2.0

85 stars 9 forks source link

FOV in deg instead of rad. #3

Open antoinefalisse opened 3 years ago

antoinefalisse commented 3 years ago

Hi,

It is not an issue per se, but I think the FOV set here is in degrees, whereas glm::perspective expects a FOV in radian here. Interestingly, it does not have a huge effect on the rendering. Yet the values of the projection matrix P are wrong should anyone would like to use them. Thought that could be useful.

Best, Antoine

MarliesNit commented 3 years ago

Hi,

thanks for pointing this out. Seems that there has been a change on how glm expects the FOV over the versions of glm: read more

This should be updated in the code.

Best, Marlies