search

madecoste / swarming

Automatically exported from code.google.com/p/swarming
Apache License 2.0
0 stars 1 forks source link

Improve /swarming/api/v1/bot/poll in case of "crash during return" #130

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Repro:
1. task_scheduler.bot_reap_task() calls in BotPollHandler.post at least 
partially succeed.
2. runtime.DeadlineExceededError is raised.

Expected:
The next polling hands out this task that was already reaped.

Actual:
The reaped task is lost.

It's really about the last 0.01% of case in this race condition that it'd be 
nice to handle this case as nicely as possible.

Original issue reported on code.google.com by maruel@chromium.org on 28 Jul 2014 at 8:25

GoogleCodeExporter commented 9 years ago 
There isn't much to do in practice and it doesn't seem to happen frequently. 
That's really an edge case.

Original comment by maruel@chromium.org on 9 Jan 2015 at 7:59