madecoste / swarming

Automatically exported from code.google.com/p/swarming
Apache License 2.0
0 stars 1 forks source link

Make --hash and --isolated options consistent #160

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Two similar commands use a different option for the isolated hash:

tools/swarming_client/run_isolated.py --hash 
499bec1a62cd670b0c2f18c809836f39fc66834c --namespace default-gzip 
--isolate-server https://isolateserver.appspot.com

but:

tools/swarming_client/isolateserver.py download  --hash 
499bec1a62cd670b0c2f18c809836f39fc66834c --namespace default-gzip 
--isolate-server https://isolateserver.appspot.com

isolateserver.py: error: no such option: --hash

Turns out the correct syntax is:

tools/swarming_client/isolateserver.py download  --isolated 
499bec1a62cd670b0c2f18c809836f39fc66834c --namespace default-gzip 
--isolate-server https://isolateserver.appspot.com

I'd suggest making it consistent, possibly allowing both --hash and --isolated 
in both places, or otherwise helping move between the two commands.

Original issue reported on code.google.com by phajdan.jr@chromium.org on 23 Sep 2014 at 8:34

GoogleCodeExporter commented 9 years ago
Took a while but finally fixed in 185ded4fe9e6da935ed93e3494fd524928ee752b.

Original comment by maruel@chromium.org on 10 Feb 2015 at 8:06