search

madnight / bitcoin-chart-cli

Bitcoin chart for the terminal as command line util
MIT License
302 stars 39 forks source link

Getting very narrow charts (on WSL) #18

Closed arielgabizon closed 4 years ago

arielgabizon commented 4 years ago

image

madnight commented 4 years ago

For all charts or only with this specific parameters?

arielgabizon commented 4 years ago

all (tried several examples)

Emobe commented 4 years ago

I'm getting these on arch linux. I just ran with no parameters. Info in screenshot 2020-05-07-134325_939x1150_scrot

madnight commented 4 years ago

yup seems to be a problem with version 3.3.1

3.3.0 works fine

okay it seems to be a problem with the dependencies, when I install with yarn (using yarn.lock) it works, with npm not

madnight commented 4 years ago

Alright fixed it, latest version npx bitcoin-chart-cli@3.3.3 works again.

The problem was that I always use yarn locally and yarn uses the yarn.lock file with a working set of versions. However, with npm you get a new set of versions depending on the versions constrains in the package.json. These constrains were to loose and npm bundled a set of versions together that did not work. I pinned the versions in package.json and also added a package-lock.json to freeze the versions for npm too.

Thx for the error reporting and patience.

arielgabizon commented 4 years ago

Thanks! Works well