Make coverage checking repeatable

mafintosh / dns-packet

An abstract-encoding compliant module for encoding / decoding DNS packets

MIT License

205 stars 71 forks source link

Make coverage checking repeatable #48

Closed hildjj closed 5 years ago

hildjj commented 5 years ago

Proposal:

[ ] add nyc as a dev dependency
[ ] Add a coverage script to package.json that generates HTML
[ ] Add coverage outputs to .gitignore

Optional, if desired (trivial for me to do, but more controversial):

[ ] Install coveralls in .travis.yml
[ ] On successful run, send output to coveralls.io
[ ] Add support for auto-refresh of the coverage HTML (makes writing coverage tests fun)

hildjj commented 5 years ago

Coverage output sample.

silverwind commented 5 years ago

Sounds good, I'd actually appreciate a coverage badge in the README, so I think this means we need to upload the reports. Note that I have no experience with coverage tools really.

hildjj commented 5 years ago

You'll need a coveralls.io account (log in with github), and turn on support for this repo by clicking the "+" on the left side, searching for the repo name, and sliding the button to "on". My PR will include a (correct) badge.