search

mafintosh / dns-packet

An abstract-encoding compliant module for encoding / decoding DNS packets
MIT License
198 stars 69 forks source link

Request for typescript definition file #59

Open lygstate opened 4 years ago

martinheidegger commented 3 years ago

Incomplete, but here: https://www.npmjs.com/package/@types/dns-packet

SgtPooki commented 9 months ago

@martinheidegger would you be open to supporting types directly in this package? definitelyTyped is huge and adding types is a significant pain. (check out the PR checklist at https://github.com/DefinitelyTyped/DefinitelyTyped/pull/67294)

martinheidegger commented 9 months ago

I don't think it will make it in the package

SgtPooki commented 9 months ago

@martinheidegger would you mind elaborating? Are you trying to keep modifications to this package low or worried about pushing back against a TS conversion?

we could add types in this package without changing the JS code at all (just including the index.d.ts from DefinitelyTyped).

silverwind commented 9 months ago

I would accept a reasonable PR that adds .d.ts.

What is the current best practice to validate those files? https://github.com/tsdjs/tsd or is there something better?