test: get_fee and assert_fee_amount to take feerate in sat_vb - Githubissues

maflcko / bitcoin-core

MIT License

26 stars 12 forks source link

test: get_fee and assert_fee_amount to take feerate in sat_vb #69

Open maflcko opened 2 years ago

maflcko commented 2 years ago

Change the btc_kb argument to sat_per_vb and adjust all call sites.

This allows to remove a lossy truncation via int.

Also, the new argument should be a forced named argument.

Useful skills:

Python 3
The functional tests
Fee rates in BTC/kB and sat/vB

Want to work on this issue?

For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.