rhoerr commented 1 month ago

Description (*)

This expands the menu options and buttons loaded in TinyMCE in the admin panel. The buttons were drastically cut back when the editor was upgraded from TinyMCE 5, including removing any font size option, and that's bad for user experience.

This PR enables all of the font/formatting buttons that people are likely to use, reenables the menu bar, and hides the 'Upgrade' promo button from that menu.

Related Pull Requests

107 upgraded TinyMCE 5 to 6

Fixed Issues (if relevant)

Fixes inability to change font size in text editor

Manual testing scenarios (*)

Go to Admin Panel > Catalog > Products
Create a product
Edit the Description
See the editor load with expanded toolbar options and menu

Questions or comments

Contribution checklist (*)

[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/integration tests (if applicable)
[ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
[ ] All automated tests passed successfully (all builds are green)

fballiano commented 1 month ago

I've tested this PR and it works as expected

before:

after:

but personally I prefer a much simpler toolbar, this one seems too much IMHO

rhoerr commented 1 month ago

Any suggestions on what specifically to take out?

It's a balancing act between making it minimal and hiding less-used things in the menu, versus making it super easy for people that aren't computer-smart. Most of the merchants I deal with that do content entry would struggle with anything that isn't right there.

The charmap and emojis could certainly be taken out, but seemed like a nice to have. Strikethrough could also probably be taken out. Maybe indent/outdent. Maybe text alignment.

For comparison, here's the menu/toolbar prior to this patch release and Tiny update:

fballiano commented 1 month ago

so, IMHO, if the first toolbar is kept (the one with the "file" menu) there's not really the need to add many icons below since they're all also inside of the first toolbar itself.

I would personally do something like this:

because I think those buttons I removed should be used less (or avoided, like changing font interline could screw the design) but are still available in the first toolbar

rhoerr commented 4 weeks ago

Updated with a bunch cut out. I opted to keep some of them. Also turned off the status bar, which just takes up space.

Wide:

Narrow:

mage-os / mageos-magento2

Improved menu/toolbar settings for TinyMCE 6 #109