magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.92k stars 781 forks source link

Attacking/Declare attacker distinction bug #10234

Open Perdogie opened 1 year ago

Perdogie commented 1 year ago

Mirri's second ability prevents opponents from declaring more than one attacker if Mirri is tapped. This does not affect creatures that enter the battlefield attacking. However, as currently coded Mirri is negating all combat damage from creatures that enter attacking (ie, Kaalia of the Vast's ability or Leonin Warleader's) and an error reports that no more than one creature may attack. The creatures are entering tapped and applying no combat damage although they should. Here I attack with Kaalia and have her trigger bring in Lord of the Void tapped and attacking. Error occurs, he deals no damage. If this error is ubiquitous for all ETB attacking instances then it will also effect cards such as Silent Arbiter and other mechanics like Ninjutsu. There needs to be a clear distinction between when the game is checking for creatures being declared as attackers or are attacking by other means and when each is applicable.

KaaliaTrigger GameMessage PostCombat
github-actions[bot] commented 1 year ago

Mirri, Weatherlight Duelist - (Gatherer) (Scryfall) (EDHREC)

{1}{G}{W} Legendary Creature — Cat Warrior 3/2 First strike Whenever Mirri, Weatherlight Duelist attacks, each opponent can't block with more than one creature this combat. As long as Mirri, Weatherlight Duelist is tapped, no more than one creature can attack you each combat.

Susucre commented 1 year ago

Similar cards are probably bugged the same way https://scryfall.com/search?q=O%3A%22can+attack%22+o%3A%22each+combat%22&unique=cards&as=grid&order=name