search

magento-hackathon / magento-composer-installer

Composer installer for Magento modules
210 stars 154 forks source link

Backslash in .gitignore on Windows #166

Closed flancer64 closed 9 years ago

flancer64 commented 9 years ago

When I have deployed project with extra parameters as

  "extra": {
    "magento-root-dir": "mage",
    "magento-deploystrategy": "symlink",
    "auto-append-gitignore": true
  }

on my Windows 7 station, I have read the following entries in the mage/.gitignore file:

...
/app/code\core\Mage\Adminhtml\Block\Catalog\Product\Composite\Configure.php
...

some slashes are forward but some are backward. Git ignores these entries when processing .gitignore, I need to change all "\" to "/" to fix ignores.

davidverholen commented 9 years ago

@AydinHassan I think this could be fixed easily in the GitIgnore class.

@AydinHassan @Flyingmana But we should also try to fix the different slashes. Seems like the glob part is taking the DIRECTORY_SEPARATOR while the modman pard keeps the '/'. This should also be converted to the systems DIRECTORY_SEPARATOR I think.

So we might just replace any separators just before writing them to the deployed or removed Files array