Issue #847 - [Wish List] Remove Wish List

magento / graphql-ce

[ARCHIVED] Please use magento/magento2 project

https://github.com/magento/magento2

Open Software License 3.0

131 stars 155 forks source link

Issue #847 - [Wish List] Remove Wish List #1024

Closed Krielkip closed 4 years ago

Krielkip commented 5 years ago

Adds removeWishlist to Graph Ql

Description (*)

Adds the graph ql mutation to remove all items on the wishlist of current customer.

Fixed Issues (if relevant)

magento/graphql-ce#847: [Wish List] Remove Wish List

Manual testing scenarios (*)

Be logged in as customer
Have minimal 1 product in wishlist
use GraphQl code:
```
mutation {
removeWishlist 
}
```

Contribution checklist (*)

[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/integration tests (if applicable)
[x] All automated tests passed successfully (all builds are green)

lenaorobei commented 5 years ago

Please note that schema for this mutation is still under the discussion https://github.com/magento/architecture/pull/326

This may cause some delays with PR processing.

Krielkip commented 5 years ago

Thanks for the replay. This issue was in the board of the Magento Live contribution Day in Amsterdam. Good to read that this schema is under discussion

TomashKhamlai commented 5 years ago

Checked test cases:

Remove Wish List with different types of products :heavy_check_mark:
Remove Wish List with OUT_OF_STOCK product :heavy_check_mark:
Remove Wish List twice :heavy_check_mark:

TomashKhamlai commented 5 years ago

Please, fix static tests.

Krielkip commented 5 years ago

I have added the folder /Test/Mtft with the Readme.md file. Still need to look how to do good static tests.

m2-community-project[bot] commented 5 years ago

@Krielkip unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

TomashKhamlai commented 5 years ago

There are some problems with the Storefront after removing the Wish List. Most likely it is a caching problem and not related to this PR. I am going to create an issue and then I will continue testing.

m2-community-project[bot] commented 5 years ago

@TomashKhamlai unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

lenaorobei commented 4 years ago

Hi @Krielkip! Unfortunately we need to close this PR in order to not to increase tech debt with new storefront approach. Hope you'll join us in upcoming project.

ghost commented 4 years ago

Hi @Krielkip, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.