magento / inventory

Magento Inventory Project (a.k.a MSI)
Open Software License 3.0
337 stars 247 forks source link

add qty check for order items #3400

Closed ejaz-alam closed 10 months ago

ejaz-alam commented 11 months ago

Description (*)

Steps to reproduce

  1. Login into admin > Sales > Orders > Open order which have multiple products(items)
  2. Create shipment for product1 (let's assume i have added Test simple, Test simple 2, Test simple 3 into cart, place an order, Login into admin > Sales > Orders > Open order, shipment created for product1 - http://i.imgur.com/q0Kg9L4.png
  3. Once shipment created for Test simple, again create new shipment for rest of two products.
  4. what i am doing, if you will create another(2nd) shipment, you can see Test simple product into Items Ordered grid - http://i.imgur.com/a4PUxeO.png
  5. when you select source, qty for ship is 0 for Test simple product, But i am able to add Qty to deduct value, while i add 1 into qty to deduct field for Test simple product, add 0 value for rest of 2 product, click on create shipment button, items to ship section not have information about the product, new shipment page looks like as per image - http://i.imgur.com/8i8bKxN.png
  6. Rest of fields leave as it is.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#38063

Manual testing scenarios (*)

Before Fix

image

After Fix

image

Questions or comments

Contribution checklist (*)

ejaz-alam commented 11 months ago

@ihor-sviziev please review.

ejaz-alam commented 11 months ago

@bgorski pls review.

magento-automated-testing[bot] commented 11 months ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo commented 10 months ago

@magento run all tests

magento-automated-testing[bot] commented 10 months ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo commented 10 months ago

@magento run Functional Tests CE

magento-automated-testing[bot] commented 10 months ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo commented 10 months ago

@ejaz-alam Internal Team is working on it and added automated test coverage along with theses changes.

engcom-Bravo commented 10 months ago

Hi @ejaz-alam,

Thanks for the collaboration & contribution!

:heavy_check_mark: QA Passed

Preconditions:

Manual testing scenario:

As per the Description.

Before: :heavy_multiplication_x:

Screenshot 2023-11-30 at 10 31 46 AM Screenshot 2023-11-30 at 10 32 49 AM

After: :heavy_check_mark:  

The one which we have shipped previously it is not appearing for second shipment.

Screenshot 2023-11-30 at 12 13 49 PM Screenshot 2023-11-30 at 12 14 06 PM