Issue when you apply discount code in review & payment tab and if this affects shipping method which is selected one step before.

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

http://www.magento.com

Open Software License 3.0

11.48k stars 9.29k forks source link

Issue when you apply discount code in review & payment tab and if this affects shipping method which is selected one step before. #29938

Closed mehmetuygun closed 3 years ago

mehmetuygun commented 4 years ago

Preconditions (*)

1.Magento 2.3.3

Steps to reproduce (*)

create a free shipping method with condition min order value 25 ( for example)
Create a discount code gives any percent off (%25)
Add product to cart
proceed to checkout, fill address, then select the free shipping option.
proceed to payment. Hold On. Apply discount code make sure now the total value is less than what free shipping requires.
try to go any payment.
Now you are getting an error "Something went wrong with your request. Please try again later"

Expected result (*)

Redirect back, and tell the customer to select the available shipping methods.

Actual result (*)

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

[ - ] Severity: S0 - Affects critical data or functionality and leaves users without a workaround.
[ -] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ - ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ - ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ - ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 4 years ago

Hi @mehmetuygun. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 4 years ago

Hi @engcom-Oscar. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Oscar commented 4 years ago

Hi @mehmetuygun, thank you for your report. I have tested this issue on latest Magento 2.4-develop branch, following steps you described in the ticket, but got a bit different result. When I applied coupon on Payment page during checkout, my shipping method got status from 'Free shipping' into 'Not yet calculated'. When I tried to place order, I got message: 'The shipping method is missing. Select the shipping method and try again.'