Coding error in tax details

hanaks commented 4 years ago

Preconditions (*)

Magento version 2.4.0

Steps to reproduce (*)

Set up Magento with a two tax classes with different rates. One for shipping and another for product. I have used setup for Norway.
Install Nets payment gateway module: https://tech.dibspayment.com/easy/webshop_modules/magento2
Configure for testing.
Submit a test order: https://tech.dibspayment.com/easy/test-information
Visit the successfully placed order in backend.

Expected result (*)

No error.

Actual result (*)

Order details in backend doesn't fully generate. There is an error in bottom, after which there is no more output: <tr id="rate-An error has happened during application run. See exception log for details.

The error happens in vendor/magento/module-sales/view/adminhtml/templates/order/totals/tax.phtml

Here is dump of $_fullInfo variable in that file:

Array
(
    [0] => Array
        (
            [amount] => 70.0000
            [base_amount] => 70.0000
            [base_real_amount] => 70.0000
            [rates] => Array
                (
                    [0] => Array
                        (
                            [code] => Mva lav
                            [title] => Mva lav
                            [percent] => 15
                            [position] => 0
                            [priority] => 0
                        )

                    [1] => Array
                        (
                            [code] => Mva Høy
                            [title] => Mva Høy
                            [percent] => 25
                            [position] => 0
                            [priority] => 0
                        )

                )

            [percent] => 40
            [id] => Mva lavMva Høy
        )

)

Order printing is affected too, error is in different file. I didn't test invoice, creditmemo, shipment and printing of these.

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

[ x] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 4 years ago

Hi @hanaks. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Morgy93 commented 4 years ago

Already reported here: #30094

m2-assistant[bot] commented 3 years ago

Hi @engcom-Alfa. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Alfa commented 3 years ago

Duplicate of #30094

Kilawuyiek commented 1 year ago

It appears that there is an error happening in the Magento sales module when trying to display the tax information for orders that have been placed using the Nets payment gateway module. The error message states that there is an error in the file "vendor/magento/module-sales/view/adminhtml/templates/order/totals/tax.phtml" and that "An error has happened during application run. See exception log for details."

It seems that this issue is caused by the fact that the tax classes in the order have the same code, "Mva lavMva Høy", which is causing the issue in displaying the tax information.

To resolve this issue, you should check the tax class configuration and make sure that the tax classes have unique codes. Alternatively, you can also contact the developer of the Nets payment gateway module for further assistance.

magento / magento2