[Issue] Bugfix - Payment Method without label position in the array

[m2-assistant[bot]]

This issue is automatically created based on existing pull request: magento/magento2#30907: Bugfix - Payment Method without label position in the array

---

Description (*)

Look at position 14 the Payment Provider may forget the label and this can break the store.

Then, to avoid this bug I put a verification.

Array
(
    [0] => Array
        (
            [value] => 
            [label] => 
        )

    [1] => Array
        (
            [value] => vault
            [label] => 
        )

    [2] => Array
        (
            [value] => mercadopago
            [label] => 
        )

    [3] => Array
        (
            [value] => substitution
            [label] => 
        )

    [4] => Array
        (
            [value] => amazon_payment
            [label] => Amazon Pay
        )

    [5] => Array
        (
            [value] => amazonlogin
            [label] => Amazon Pay
        )

    [6] => Array
        (
            [value] => mercadopago_custom_bank_transfer
            [label] => Bank Transfer - Mercado Pago
        )

    [7] => Array
        (
            [value] => Array
                (
                    [braintree_ach_direct_debit] => Array
                        (
                            [value] => braintree_ach_direct_debit
                            [label] => ACH Direct Debit
                        )

                    [braintree_applepay] => Array
                        (
                            [value] => braintree_applepay
                            [label] => Apple Pay
                        )

                    [braintree] => Array
                        (
                            [value] => braintree
                            [label] => Credit Card
                        )

                    [braintree_googlepay] => Array
                        (
                            [value] => braintree_googlepay
                            [label] => Google Pay
                        )

                    [braintree_local_payment] => Array
                        (
                            [value] => braintree_local_payment
                            [label] => Local Payments
                        )

                    [braintree_paypal] => Array
                        (
                            [value] => braintree_paypal
                            [label] => PayPal
                        )

                    [braintree_paypal_credit] => Array
                        (
                            [value] => braintree_paypal_credit
                            [label] => PayPal Credit
                        )

                    [braintree_paypal_vault] => Array
                        (
                            [value] => braintree_paypal_vault
                            [label] => Stored Accounts (PayPal)
                        )

                    [braintree_cc_vault] => Array
                        (
                            [value] => braintree_cc_vault
                            [label] => Stored Cards
                        )

                    [braintree_venmo] => Array
                        (
                            [value] => braintree_venmo
                            [label] => Venmo
                        )

                )

            [label] => Braintree
        )

    [8] => Array
        (
            [value] => mercadopago_custom
            [label] => Credit Card - Mercado Pago
        )

    [9] => Array
        (
            [label] => Klarna
            [value] => Array
                (
                    [klarna_kp] => Array
                        (
                            [value] => klarna_kp
                            [label] => Klarna Payments
                        )

                )

        )

    [10] => Array
        (
            [value] => Array
                (
                    [banktransfer] => Array
                        (
                            [value] => banktransfer
                            [label] => Bank Transfer Payment
                        )

                    [cashondelivery] => Array
                        (
                            [value] => cashondelivery
                            [label] => Cash On Delivery
                        )

                    [checkmo] => Array
                        (
                            [value] => checkmo
                            [label] => Check / Money order
                        )

                    [free] => Array
                        (
                            [value] => free
                            [label] => No Payment Information Required
                        )

                    [purchaseorder] => Array
                        (
                            [value] => purchaseorder
                            [label] => Purchase Order
                        )

                )

            [label] => Offline Payment Methods
        )

    [11] => Array
        (
            [value] => Array
                (
                    [payflow_advanced] => Array
                        (
                            [value] => payflow_advanced
                            [label] => Credit Card (Payflow Advanced)
                        )

                    [payflow_link] => Array
                        (
                            [value] => payflow_link
                            [label] => Credit Card (Payflow Link)
                        )

                    [payflowpro] => Array
                        (
                            [value] => payflowpro
                            [label] => Credit Card (Payflow Pro)
                        )

                    [paypal_billing_agreement] => Array
                        (
                            [value] => paypal_billing_agreement
                            [label] => PayPal Billing Agreement
                        )

                    [payflow_express_bml] => Array
                        (
                            [value] => payflow_express_bml
                            [label] => PayPal Credit (Payflow Express Bml)
                        )

                    [paypal_express_bml] => Array
                        (
                            [value] => paypal_express_bml
                            [label] => PayPal Credit (Paypal Express Bml)
                        )

                    [paypal_express] => Array
                        (
                            [value] => paypal_express
                            [label] => PayPal Express Checkout
                        )

                    [payflow_express] => Array
                        (
                            [value] => payflow_express
                            [label] => PayPal Express Checkout Payflow Edition
                        )

                    [hosted_pro] => Array
                        (
                            [value] => hosted_pro
                            [label] => Payment by cards or by PayPal account
                        )

                    [payflowpro_cc_vault] => Array
                        (
                            [value] => payflowpro_cc_vault
                            [label] => Stored Cards (Payflow Pro)
                        )
                )
            [label] => PayPal
        )

    [12] => Array
        (
            [value] => mercadopago_basic
            [label] => Quiero pagar con Mercado Pago sin costo Adicional.
        )

    [13] => Array
        (
            [value] => mercadopago_customticket
            [label] => Ticket - Mercado Pago
        )

    [14] => Array
        (
            [value] => Array
                (
                    [pagseguro] => Array
                        (
                            [value] => pagseguro
                            [label] => PagSeguro
                        )
                )
        )
)

Related Pull Requests

No

Manual testing scenarios (*)

Anyone who sends a multiple arrays without a label will break the store, especially in the admin.

Questions or comments

Contribution checklist (*)

• [x] Pull request has a meaningful description of its purpose
• [x] All commits are accompanied by meaningful commit messages
• [ ] All new or changed code is covered with unit/integration tests (if applicable)
• [ ] All automated tests passed successfully (all builds are green)

[andreustimm]

Almost a year, in Magento 3.0 they will fix :(

[m2-assistant[bot]]

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Hello @andreustimm,

Thank you for the report and collaboration!

Can you please elaborate the description, where is this causing the issue and please mention the steps to reproduce, and also the use case for the same.

[engcom-November]

Hello @andreustimm,

As there is no activity on this issue for a long time, we believe the issue has been resolved, hence closing this issue. Feel free to raise a new issue or reopen this if you need more assistance.

Thank you.