magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.57k stars 9.32k forks source link

PayPal Express InContext SmartButton on product page is missing an availability check #34669

Open codebase-md opened 3 years ago

codebase-md commented 3 years ago

Preconditions (*)

  1. Magento 2.4.3

Steps to reproduce (*)

There are no specific steps. We developed an extension that restricts payment methods by listening to the event 'payment_method_is_active' fired in this function. This works fine for all cases with one exception. The PayPal Express InContext SmartButton. For this one the availability check is missing.

Expected result (*)

The function shouldRender() should implement an availability check like this function providing the possiblity for restrictions.

Actual result (*)

Availability check is missing. Due to this a restriction is not possible without going an extra mile.

Additional Info (*)

We are able to reproduce it on Magento 2.4-develop/2.4.3/2.4.3-p1. As per your steps, we tried to reproduce this bug.

1

2


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

m2-assistant[bot] commented 3 years ago

Hi @codebase-md. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 3 years ago

Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Hotel commented 3 years ago

Hi @codebase-md,

Thank you for reporting the issue.

We are able to reproduce it on Magento 2.4-develop/2.4.3/2.4.3-p1. As per your steps, we tried to reproduce this bug.

1

2

Hence confirming this issue

Thank You

github-jira-sync-bot commented 3 years ago

:white_check_mark: Jira issue https://jira.corp.magento.com/browse/AC-1824 is successfully created for this GitHub issue.

m2-assistant[bot] commented 3 years ago

:white_check_mark: Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.