magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.58k stars 9.32k forks source link

PayPal IPN Fails with Multiple Merchant Accounts #34993

Closed 0xMatt closed 2 years ago

0xMatt commented 2 years ago

Preconditions (*)

  1. CentOS 8
  2. PHP 7.4
  3. Magento 2.4.3-p1

Steps to reproduce (*)

  1. Setup default PayPal Pro merchant account information used by primary store
  2. Setup secondary PayPal Pro merchant account scoped to the secondary website config

Expected result (*)

  1. IPN posts back successfully

Actual result (*)

  1. Error occurs, IPN does not use the store ID from the order
 main.CRITICAL: The requested "merchant@example1.com" and the configured "merchant@example2.com" merchant emails don't match. {"exception":"[object] (Exception(code: 0): The requested \"merchant@example1.com\" and the configured \"merchant@example2.com\" merchant emails don't match. at /var/www/html/magento/vendor/magento/module-paypal/Model/Ipn.php:123)"} []

The IPN posts back to my website id 2, but it's comparing with the email from website id 0(admin).

This results in complete failures of postback notifications.


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

m2-assistant[bot] commented 2 years ago

Hi @0xMatt. Thank you for your report. To speed up processing of this issue, make sure that you provided the following information:

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

0xMatt commented 2 years ago

I cannot provide my PayPal credentials into a demo instance. How should I go about reproducing this? I can provide access to my server from a Magento staff member, but that's about it as far as giving any sort of access to our merchant information.

engcom-Lima commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Lima. Thank you for your request. I'm working on Magento instance for you.

m2-assistant[bot] commented 2 years ago

Hi @engcom-Lima. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Lima, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Lima commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Lima. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Lima, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Lima commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Lima. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Lima, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Hotel commented 2 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 years ago

Hi @engcom-Hotel, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Lima commented 2 years ago

Hi @0xMatt, I tried digging deep into the issue, from the code base and the log It seems that Magento is loading the proper store view i.e second store but the email we get in response from PayPal is different than what is configured for the second store scope.

File: \Magento\Paypal\Model\Ipn::_getConfig

// verify merchant email intended to receive notification
        $merchantEmail = $this->_config->getValue('businessAccount');
        if (!$merchantEmail) {
            return $this->_config;
        }
        $receiver = $this->getRequestData('business') ?: $this->getRequestData('receiver_email');
        if (strtolower($merchantEmail) != strtolower($receiver)) {
            // phpcs:ignore Magento2.Exceptions.DirectThrow
            throw new Exception(
                sprintf(
                    'The requested "%s" and the configured "%s" merchant emails don\'t match.',
                    $receiver,
                    $merchantEmail
                )
            );
        }

As you can see in the code base Magento tries to match the email configured in second store with the email received in Paypal response data. Proper data is loaded from Magento end e.g for Second Store View email merchant@example2.com is loaded correctly.

Can you please try to verify in your Paypal account the same email is configured as that in your Magento instance.

Thanks!

engcom-Hotel commented 2 years ago

Dear @0xMatt,

We have noticed that this issue has not been updated for a period of 14 Days. Hence we assume that this issue is fixed now, so we are closing it. Please raise a fresh ticket or reopen this ticket if you need more assistance on this.

Regards

atty31 commented 4 months ago

I m still facing this on M2.4.6, any updates on this one ?